Ticket #108 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Tag assignments can be deleted accidentally

Reported by: tklein Owned by: tklein
Priority: critical Milestone: 0.3
Component: Tagging System Keywords:
Cc: wblanton

Description

At the moment it is fairly easy to delete tag assignments accidentally. This is especially painful if a bigger number of verses is affected. The UI should confront the user with a confirmation dialogue as soon as he tries to delete tag assignments for more than 1 verse.

Change History

Changed 2 years ago by tklein

  • status changed from new to accepted

Changed 2 years ago by tklein

  • status changed from accepted to closed
  • resolution set to fixed

(In [187])

  • Adaptions that are part of the solution for the splitted verse inconsistencies (see #129)
    • Added attribute "verse_part" to verse_tags and verse_notes (see new migration scripts),
    • verse_tags are not destroyed by the ids anymore. Instead we take the verse references as unique identifier.
    • The tags of a verse are now fetched with the verse_part as parameter (changed Verse.tags)
    • Adapted Tag.create_or_find_from_user_data (added verse_part parameter)
    • Adapted controller functions in assigned_tags_controller and tagged_verses_controller
  • Properly handle the creation of sections that contain both other sections and verses (fixes #121)
    • Added OutlineSection?.is_within_passage
    • Added OutlineSection?.move_to_new_parent_section
    • Check inner sections of new section container upon creation and create the appropriate data elements within section_tree
    • Adapted verse_range jquery selector so that it would also match section elements within a passage
  • Show a confirmation dialog before removing tag assignments for a verse list longer than 1 verse (fixes #108)
  • Show a confirmation dialog before moving verses with the result of dissolving a section (fixes #102)
  • _verse_box.erb => Only query verse note if the currently computed verse really has one (Performance improvement)
  • Refactored the tag-data-element that contains the tag information within the verse list
  • Fix some event handling issues with the bible browser checkbox buttons
  • Remove local tags from verse_list upon destruction of a tag
  • Show note and tag indicators permanently. Now these indicators are gray if no tags or notes are available, and blue if so.
  • Reduze font-size of dialogs
Note: See TracTickets for help on using tickets.