Ticket #6 (closed task: fixed)

Opened 2 years ago

Last modified 2 years ago

Notes functionality

Reported by: tklein Owned by: tklein
Priority: blocker Milestone: 0.3
Component: Notes functionality Keywords:
Cc:

Description (last modified by tklein) (diff)

It should be possible to to take notes for passages.
The creation of contents shall be done with wiki style syntax.

Details about the concept are described in the following wiki page:

Notes functionality

Change History

  Changed 2 years ago by tklein

  • owner set to tklein
  • status changed from new to accepted
  • component set to General

  Changed 2 years ago by tklein

  • description modified (diff)
  • summary changed from Commenting functionality to Notes functionality

  Changed 2 years ago by tklein

(In [155]) First implementation steps for verse notes (see #6)

  • Added a switch checkbox for the verse notes
  • Added verse-notes element to verse-box
  • Changed reference_to_verse_nr for splitted verses. The second half of a splitted verse is now getting a 0.5 value for the verse-nr, With that change we can get rid of the nasty adaptions in verse_range
  • Style improvement: Don't indent fist level sections
  • Reduced size of book-select-button a little bit

  Changed 2 years ago by tklein

(In [172])
fixes #117,#119,#100,#94

  • Added new notes controller as a preparation for the note taking functionality (see #6)
  • Summarized the controller init functions in main.js in one new function (init_controller)
  • Bugfix: Don't load book specific tag list in Tag Browser if no book is selected

  Changed 2 years ago by tklein

(In [173]) * Added jquery.elastic module for auto growing text areas

  • First version of usable note taking functionality (see #6)
  • Bugfixes for book menu

  Changed 2 years ago by tklein

(In [174]) updated gem dependencies (need RedCloth? for textile stuff now, see #6)

  Changed 2 years ago by tklein

(In [175]) * Added verse_notes serverside adaptions (including migration for new table verse_notes)

  • Added plugin for textile wiki rendering (see #6)

  Changed 2 years ago by tklein

(In [176]) Added elastic library for auto growing textareas (see #6)

  Changed 2 years ago by tklein

(In [177]) Added textile rendering support for strikethrough text (see #6)

  Changed 2 years ago by tklein

(In [178]) * Small bugfixes and optimizations for notes function (see #6)

  • Display a loading indicator while loading textile text from server
  • Adapted split verse event handling, since it affects the note click events

  Changed 2 years ago by tklein

(In [179]) Further bugfixes for notes functionality (see #6)

  • Transfer textile text as xml, because of browser issues
  • Don't load verse from server if html is empty

follow-up: ↓ 13   Changed 2 years ago by wblanton

Are you still working on this? I'm not sure whether or not you are aware, but as of right now, when a note is typed and then that area is re-clicked, it deletes any information that was previously there...

Also, when a note is typed into one box, once you are finished, if you click onto another editable text box it duplicates what you had just written in the previous. When you delete it, when clicking around, it sometimes randomly appears back with the text that was deleted. Some boxes also when clicked on don't revert back to "click to add notes to this verse"

in reply to: ↑ 12   Changed 2 years ago by tklein

Replying to wblanton:

Are you still working on this? I'm not sure whether or not you are aware, but as of right now, when a note is typed and then that area is re-clicked, it deletes any information that was previously there...

Also, when a note is typed into one box, once you are finished, if you click onto another editable text box it duplicates what you had just written in the previous. When you delete it, when clicking around, it sometimes randomly appears back with the text that was deleted. Some boxes also when clicked on don't revert back to "click to add notes to this verse"

Yes, I've still been working on this... the problems you've described should all be solved!

  Changed 2 years ago by tklein

(In [182]) * Bugfix for the case of non existent notes in verse_notes_controller

  • Some small (but nice!) style optimizations for the note taking UI (see #6)
  • Added time fields for the notes in database (added migration script)

  Changed 2 years ago by tklein

  • priority changed from major to blocker

  Changed 2 years ago by tklein

  • component changed from General to Note functionality

  Changed 2 years ago by tklein

  • status changed from accepted to closed
  • resolution set to fixed

A first (usable) version of this functionality is now ready to be used...

Note: See TracTickets for help on using tickets.